Skip to content

Use docker with prebuild dependencies #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

igchor
Copy link

@igchor igchor commented Dec 17, 2021

This change is Reviewable

Copy link
Collaborator

@raema raema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed that the workflow completed with the new image. looks great to me.

@igchor igchor merged commit 3e303d3 into pmem:develop Dec 17, 2021
@@ -8,12 +8,8 @@ jobs:
name: "CentOS/latest - Build CacheLib with all dependencies"
runs-on: ubuntu-latest
# Docker container image name
container: "centos:latest"
container: "ghcr.io/igchor/cachelib-deps:centos8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It looks like a personal setting infiltrating the yaml file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrambacher this is a temporary workaround - I want to change it to pmem organization but it requires the admin to make the package public (and he is on vacation right now)

danielobiri pushed a commit to danielobiri/CacheLib that referenced this pull request Oct 25, 2022
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Nov 12, 2022
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Dec 15, 2022
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.

remove extra whitespace

Background data movement (pmem#20)

Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.

remove extra whitespace

removed the slab approx free percent check since it the value is close to 9.5 but not guaranteed to be >= 9.5
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 2, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 10, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 15, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 16, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 16, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 24, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 27, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 27, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 27, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Feb 28, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Mar 3, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Mar 3, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Jul 24, 2023
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.

fix race in promotion where releaseBackToAllocator
was being called before wakeUpWaiters.

reinsert to mm container on failed promotion
byrnedj added a commit to byrnedj/CacheLib that referenced this pull request Mar 12, 2024
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.

fix race in promotion where releaseBackToAllocator
was being called before wakeUpWaiters.

reinsert to mm container on failed promotion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants