feat(helm): add an ability to mount extra volumes#446
Merged
burningalchemist merged 4 commits intoburningalchemist:masterfrom Feb 24, 2024
Merged
feat(helm): add an ability to mount extra volumes#446burningalchemist merged 4 commits intoburningalchemist:masterfrom
burningalchemist merged 4 commits intoburningalchemist:masterfrom
Conversation
Owner
|
@allanger Thanks, I'll have a look today. 👍 |
burningalchemist
approved these changes
Feb 21, 2024
Owner
burningalchemist
left a comment
burningalchemist
left a comment
There was a problem hiding this comment.
@allanger Looks good to me! Let's give it a shot. 🚀
burningalchemist
requested changes
Feb 21, 2024
Owner
burningalchemist
left a comment
burningalchemist
left a comment
There was a problem hiding this comment.
Do you mind also updating the readme for createConfig?
Contributor
Author
|
Yes, sure, will try to do it within next couple of days |
burningalchemist
approved these changes
Feb 24, 2024
burningalchemist
changed the title
This was referenced Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR that is supposed to cover both
I haven't added new tests, I think it might make sense, but I would first wait for a @burningalchemist opinion in the approach