feat(helm): Add extraVolumes and extraVolumeMounts#432
feat(helm): Add extraVolumes and extraVolumeMounts#432duynguyenhoang wants to merge 1 commit intoburningalchemist:masterfrom
Conversation
|
Hey @duynguyenhoang thanks for your contribution! 👍 @allanger could you please review this PR whenever you have some time? 🙂 |
|
Will do it tomorrow |
| ## - spec for VolumeMount: | ||
| ## https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#volumemount-v1-core | ||
| ## | ||
| extraVolumeMounts: [] |
There was a problem hiding this comment.
Just as a suggestion. If these Volumes and Mounts are not supposed to exist one without another, maybe it's better to add one property to values, and then use it in templates, to make sure that every volume is always mounted?
There was a problem hiding this comment.
I've added a wee comment about the chart part.
But I think I have a questing regarding the exporter part. Is it not the same thing that's done by: #397? This (for example json) config that is mounted in this repo is supposed to server the same purpose as the secret/config mounted there?
If yes, maybe we can combine these 2 PRs, because I think that the from approach that is used there is easier for chart users than defining the whole volumes/mounts thingy
|
Closed in favour of #446. |
3 participants
I would like to use json file in secret (Bigquery credential for example) and mount it to container. This PR will allow us to do that.