Bump docker dependency to v20.10.0-beta#960
Conversation
|
looks like |
|
Hey @nkubala , thanks for the PR! Yes, if you could fix the imports (either by hand or by |
Signed-off-by: Nick Kubala <nkubala@google.com>
Codecov Report
@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 103 103
Lines 5005 5005
=======================================
Hits 3885 3885
Misses 725 725
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@dfreilich fixed everything up. codecov is failing, but since this doesn't really introduce any new code i'm not sure how to fix it apart from writing you guys some new tests :) let me know what i should do. |
|
@nkubala I'm sure we can overlook codecov :D We recently ran into dependency issue in relation to docker (aka moby/moby). You can see the details here. I realize that this is a newer version and that given the fact that it compiles and none of the tests fail, it should provide a higher level of compatibility. Out of curiosity, have you requested that this newer version also be update in go-containerregistry. I see that skaffold also uses go-containerregistry. |
|
@jromero haven't we all run into dependency issues with moby/moby 😆 hopefully this change will only alleviate some pain in the future though. i haven't bumped go-containerregistry yet, but it was a source of several transitive dependencies that cause pain in skaffold so it'll likely be next up :) is this PR ok to merge? |
jromero
left a comment
There was a problem hiding this comment.
Let's give it a shot. 🤞
If we find some issues we will have to revert.
|
sounds good, if it ends up getting reverted tag me and i can try and look again. |
Summary
Updates the version of the
docker/dockerdependency tov20.10.0-beta, specifically to matchmoby/buildkit.Selfishly, this is done so that we can resolve a dependency issue in https://github.com/GoogleContainerTools/skaffold, where we vendor both buildkit and pack.
This change is non-functional.
Output
N/A
Documentation
Related
Resolves #___