-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute the library only as aar (not as jar) #91
Changes from all commits
d51aa8e
c8599e3
c63a362
921cd36
047160c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,17 @@ | ||
-keepattributes LineNumberTable,SourceFile | ||
-dontoptimize | ||
# Add project specific ProGuard rules here. | ||
# By default, the flags in this file are appended to flags specified | ||
# in <android-sdk>/tools/proguard/proguard-android.txt | ||
# You can edit the include path and order by changing the proguardFiles | ||
# directive in build.gradle. | ||
# | ||
# For more details, see | ||
# http://developer.android.com/guide/developing/tools/proguard.html | ||
|
||
# Add any project specific keep options here: | ||
|
||
# If your project uses WebView with JS, uncomment the following | ||
# and specify the fully qualified class name to the JavaScript interface | ||
# class: | ||
#-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
# public *; | ||
#} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,9 @@ | |
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
package="com.bugsnag.android" | ||
android:versionCode="1" | ||
android:versionName="1.0" > | ||
android:versionName="1.0"> | ||
|
||
<!-- Required: Used to deliver Bugsnag crash reports --> | ||
<uses-permission android:name="android.permission.INTERNET" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Its nice to be able to guarantee this is enabled as well. 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is one of the reasons for this PR 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course, just good to see it in action. :) |
||
|
||
</manifest> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there some history behind keeping
*
instead of justcom.bugsnag.*
here, @snmaynard?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current master the proguard rules are only used during the build of the library itself so only classes in this library are affected by
-keep public class *
.With this PR the proguard rules aren't used during the build of library anymore but during the build of the app which includes the library. With the change above we make sure the rule still only affects the library and not the whole app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that rings a bell. Thanks. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kattrali I wonder if the rule is needed at all when proguard runs during the app-build instead of during the library-build