Distribute the library only as aar (not as jar) #91
Conversation
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | ||
|
|
||
| <!-- Optional: To see which Activity was active at the time of a crash --> | ||
| <uses-permission android:name="android.permission.GET_TASKS" /> |
There was a problem hiding this comment.
I wouldn't put these two here as they are automatically added to all consumers requiring opt-out. Opt-in seems a much better strategy for the optional permissions.
larsgrefer
force-pushed
the
feature/aarNotJar
branch
from
57aeadc to
4d96421
Compare
| @@ -49,13 +43,12 @@ Configuring Your AndroidManifest | |||
| </application> | |||
| ``` | |||
|
|
|||
| - Enable the `INTERNET`, `ACCESS_NETWORK_STATE` and `GET_TASKS` permissions: | |||
| - Optional: Enable the `ACCESS_NETWORK_STATE` and `GET_TASKS` permissions: | |||
There was a problem hiding this comment.
I'd rather say "recommended" here, since having these available massively aids in debugging. We can possibly remove GET_TASKS since we get this information by default now in Android 5.0+.
There was a problem hiding this comment.
@loopj What is your opinion about this comment by @JakeWharton : #91 (comment)
There was a problem hiding this comment.
I agree with Jake, these should not be automatically added (only INTERNET should be automatic, as it is 100% required).
larsgrefer
force-pushed
the
feature/aarNotJar
branch
from
4d96421 to
da8a0f5
Compare
larsgrefer
force-pushed
the
feature/aarNotJar
branch
from
e75a31d to
5adf6b3
Compare
|
The PR is ready to merge now. Please review and merge @kattrali |
this removes all proguard rules which are already present in the default proguard config of the android-sdk
larsgrefer
force-pushed
the
feature/aarNotJar
branch
from
5adf6b3 to
047160c
Compare
|
This looks good to me. Is there any reason we would need to keep jar distribution around? /cc @snmaynard |
| android:versionName="1.0"> | ||
|
|
||
| <!-- Required: Used to deliver Bugsnag crash reports --> | ||
| <uses-permission android:name="android.permission.INTERNET" /> |
There was a problem hiding this comment.
Its nice to be able to guarantee this is enabled as well. 👍
There was a problem hiding this comment.
That is one of the reasons for this PR 👍
see #50
There was a problem hiding this comment.
Of course, just good to see it in action. :)
|
@kattrali What is the current status of this? |
Android Changelog ==== ## 3.4.0 (2016-03-09) ### Enhancements - Limit the number of stored errors [Duncan Hewett](https://github.com/duncanhewett) [#97](bugsnag/bugsnag-android#97) ### Bug Fixes - Fix `ConcurrentModificationException` which could occur when saving breadcrumbs [Duncan Hewett](https://github.com/duncanhewett) [#98](bugsnag/bugsnag-android#98) - Localize all numbers in error metrics [Delisa Mason](https://github.com/kattrali) [#100](bugsnag/bugsnag-android#100) 3.3.0 (2016-01-18) ----- ### Enhancements - Change distribution method to be .aar only [Lars Grefer](https://github.com/larsgrefer) [#91](bugsnag/bugsnag-android#91) - Skip sending empty device data values [Matthias Urhahn](https://github.com/d4rken) [#96](bugsnag/bugsnag-android#96) - Remove the need for synthetic methods [Jake Wharton](https://github.com/JakeWharton) [#87](bugsnag/bugsnag-android#87) 3.2.7 (2015-12-10) ----- ### Enhancements - Add additional check to ensure the cache of uploaded errors are deleted [#80](bugsnag/bugsnag-android#80) ### Bug Fixes - Fix exception which occurs when `appContext.getResources()` is null [#78](bugsnag/bugsnag-android#78) - Fix bug preventing `maxBreadcrumbs` from being set [David Wu](https://github.com/wuman) [#70](bugsnag/bugsnag-android#70) 3.2.6 ----- - Add blocking API - Fix NPE issue - Concurrent adding to tabs - Thread Safe DateUtils#toISO8601
Fixes an issue in metadata key serialization where the key names were replaced entirely with underscores.
see and close #90