-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in new versions from makego
#3342
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,9 +7,8 @@ $(call _assert_var,CACHE_VERSIONS) | |
$(call _assert_var,CACHE_BIN) | ||
|
||
# Settable | ||
# https://github.com/protocolbuffers/protobuf-go/releases 20240611 checked 20240612 | ||
# TODO: Change back to released version once bug is fixed | ||
PROTOC_GEN_GO_VERSION ?= 94ecbc26168965a670a0f7cf86f658131c790a9c | ||
# https://github.com/protocolbuffers/protobuf-go/releases 20240906 checked 20240916 | ||
PROTOC_GEN_GO_VERSION ?= v1.34.3-0.20240906163944-03df6c145d96 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this being done? We have always used commits here, not Go pseudo-versions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this was approved in https://github.com/bufbuild/makego/pull/153/files There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK it's fine |
||
|
||
GO_GET_PKGS := $(GO_GET_PKGS) \ | ||
google.golang.org/protobuf/proto@$(PROTOC_GEN_GO_VERSION) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW we're on v1.42.0 now, but not that important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this won't affect
bufbuild/buf
, but it's a good note to updatemakego
for our other projects.