Pull in new versions from makego
#3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
reviewed
Sep 24, 2024
| # https://github.com/bufbuild/buf/releases 20240521 checked 20240524 | ||
| BUF_VERSION ?= v1.32.1 | ||
| # https://github.com/bufbuild/buf/releases 20240911 checked 20240916 | ||
| BUF_VERSION ?= v1.41.0 |
There was a problem hiding this comment.
FWIW we're on v1.42.0 now, but not that important.
There was a problem hiding this comment.
Yeah, this won't affect bufbuild/buf, but it's a good note to update makego for our other projects.
bufdev
reviewed
Sep 24, 2024
| # TODO: Change back to released version once bug is fixed | ||
| PROTOC_GEN_GO_VERSION ?= 94ecbc26168965a670a0f7cf86f658131c790a9c | ||
| # https://github.com/protocolbuffers/protobuf-go/releases 20240906 checked 20240916 | ||
| PROTOC_GEN_GO_VERSION ?= v1.34.3-0.20240906163944-03df6c145d96 |
There was a problem hiding this comment.
Why is this being done? We have always used commits here, not Go pseudo-versions
There was a problem hiding this comment.
Looks like this was approved in https://github.com/bufbuild/makego/pull/153/files
bufdev
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the latest versions from
makegoand runsmake upgrade.This adds a new check from
golangci-lint,G115, which checks for overflowfrom integer conversions. This PR includes fixes and exemptions for this check.
The check has several false positives that are still being worked on (a link to the
issue is included in the comments in
.golangci.yml) so exemptions have been addedto address false positives and/or known safe operations.