-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom lint and breaking change plugins #3279
Conversation
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
go.mod
Outdated
go 1.21.0 | ||
|
||
toolchain go1.23.0 | ||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out if this is OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine if we're requiring Go 1.22+:
go
: minimum version required for the language features in the module (that are not behind a build flag)
toolchain
: recommended stdlib and compiler to use when building the module (ignored transitively), must be greater than or equal to the go
directive (and elided if equal)
It's dense, but the docs on toolchains are helpful.
Starting in buf v1.40 my generated .pb.go file headers changed from:
to
It looks like this PR upgraded |
You've commented this in three separate places - as explained in the issue, this has no effect on your generated code. Yes, this was intentional. |
No description provided.