Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom lint and breaking change plugins #3279

Merged
merged 312 commits into from
Sep 4, 2024
Merged

Add custom lint and breaking change plugins #3279

merged 312 commits into from
Sep 4, 2024

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Aug 30, 2024

No description provided.

@bufdev bufdev added the WIP label Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 4, 2024, 8:17 PM

go.mod Outdated
go 1.21.0

toolchain go1.23.0
go 1.22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out if this is OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine if we're requiring Go 1.22+:

go: minimum version required for the language features in the module (that are not behind a build flag)
toolchain: recommended stdlib and compiler to use when building the module (ignored transitively), must be greater than or equal to the go directive (and elided if equal)

It's dense, but the docs on toolchains are helpful.

@bufdev bufdev removed the WIP label Sep 4, 2024
@bufdev bufdev merged commit 3075720 into main Sep 4, 2024
11 checks passed
@bufdev bufdev deleted the bufplugin branch September 4, 2024 21:39
@NathanBaulch
Copy link

Starting in buf v1.40 my generated .pb.go file headers changed from:

// 	protoc-gen-go v1.34.2

to

// 	protoc-gen-go v1.34.2-devel

It looks like this PR upgraded google.golang.org/protobuf to the unreleased development version v1.34.3-0.20240816073751-94ecbc261689. Was this intentional?

@bufdev
Copy link
Member Author

bufdev commented Sep 15, 2024

You've commented this in three separate places - as explained in the issue, this has no effect on your generated code. Yes, this was intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants