-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protosourcepath package #3224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a SUPER basic prototype of the state machine for top-level declarations: enums, messages, fields, services, and methods. This handles nested type declarations. This also includes a small CLI utility for testing the package. Up next/TODO's: option types, then extensions and reservations.
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs work but we've logged what that is, merging into bufplugin so I can use this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new package,
protosourcepath
. The API isa single function,
GetAssociatedSourcePaths
that takes aprotoreflect.SourcePath
and the option to
excludeChildAssociatedPaths
, and returns a list of associated paths,[]protoreflect.SourcePath
:excludeChildAssociatedPaths
will only include complete/top-level declarations as associated pathsSemantics
[4, 0, 2, 0]
would have the following associated paths:[4, 0, 2, 0]
the field definition[4, 0]
the message definition (parent path)[4, 0, 1]
the message name (parent associated child path)[4, 0, 2, 0, 1]
the field name (child path)[4, 0, 2, 0, 3]
the field number (child path)[4, 0, 2, 0, 5]
the field type (child path)[4, 0, 2, 0, 6]
the field type name (child path)[4, 0, 2, 0, 4]
the field label (child path)excludeChildAssociatedPaths == true
, then child paths and parent-associated child paths would not be included.[4, 0, 2, 0]
the field definition[4, 0]
the message definition (parent path)Implementation
GetAssociatedSourcePaths
iterates through path elements and checks them through a DFA.the next state and associated source paths: