pull request #5
Merged
pull request #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a typo. I think the correct behavior is that GoodTuring should take into account a vocab and encoding if given.
* added support for online linear regression * added test * Addressed reviewer's concern * Refactor update method, add documentation * Expand linear regression unit test Co-authored-by: Kenneth Odoh <kenluck2001@yahoo.com> Co-authored-by: ddbourgin <ddbourgin@gmail.com>
* added support for online linear regression * added test * Addressed reviewer's concern * Refactor update method, add documentation * Expand linear regression unit test * Allow multi-sample updates from the update method * Update tests for linear regression Co-authored-by: Kenneth Odoh <kenluck2001@yahoo.com>
* readme first draft * added gaussianNB * added __init__ file * unit test for gaussianNB * update readme * update readme * Move naive bayes classifer under linear models * Add more stringent tests for GaussianNBClassifier * Overhaul GaussianNBClassifier: fix log posterior calc, fix attribute names + descriptions, expand documentation * Update README for GaussianNBClassifier Co-authored-by: ddbourgin <ddbourgin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request