Bugfix: pass through vocab/encoding params #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a typo. I think the correct behavior is that GoodTuring should take into account a vocab and encoding if given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a typo. I think the correct behavior is that GoodTuring should take into account a vocab and encoding if given.
Side note: How do you run the tests in this repo?
I tried evaluating
tests/test_ngram.pyin a REPL but got an error aboutattempted relative import with no known parent package. I tried runningpython -m unittestbut got aModuleNotFoundError: No module named 'librosa.core.time_frequency'. I resorted topython -c 'from numpy_ml.tests import test_ngram; test_ngram.some_test(). Noting that there's not a test for GoodTuring yet.