add support for calling ECDSA signatures RSA signatures, cuz node allows it

.travis.yml

@@ -1,11 +1,12 @@
 sudo: false
 language: node_js
 node_js:
-  - "0.10"
   - "0.11"
   - "0.12"
   - "4"
   - "5"
+  - "6"
+  - "7"
 matrix:
   include:
     - node_js: "4"

browser/algorithms.json

@@ -5,7 +5,7 @@
     "id": "302d300d06096086480165030402040500041c"
   },
   "RSA-SHA224": {
-    "sign": "rsa",
+    "sign": "ecdsa/rsa",
     "hash": "sha224",
     "id": "302d300d06096086480165030402040500041c"
   },
@@ -15,7 +15,7 @@
     "id": "3031300d060960864801650304020105000420"
   },
   "RSA-SHA256": {
-    "sign": "rsa",
+    "sign": "ecdsa/rsa",
     "hash": "sha256",
     "id": "3031300d060960864801650304020105000420"
   },
@@ -25,7 +25,7 @@
     "id": "3041300d060960864801650304020205000430"
   },
   "RSA-SHA384": {
-    "sign": "rsa",
+    "sign": "ecdsa/rsa",
     "hash": "sha384",
     "id": "3041300d060960864801650304020205000430"
   },
@@ -35,7 +35,7 @@
     "id": "3051300d060960864801650304020305000440"
   },
   "RSA-SHA512": {
-    "sign": "rsa",
+    "sign": "ecdsa/rsa",
     "hash": "sha512",
     "id": "3051300d060960864801650304020305000440"
   },

browser/index.js

@@ -38,7 +38,7 @@ Sign.prototype.update = function update (data, enc) {
 Sign.prototype.sign = function signMethod (key, enc) {
   this.end()
   var hash = this._hash.digest()
-  var sig = sign(Buffer.concat([this._tag, hash]), key, this._hashType, this._signType)
+  var sig = sign(hash, key, this._hashType, this._signType, this._tag)
 
   return enc ? sig.toString(enc) : sig
 }
@@ -72,7 +72,7 @@ Verify.prototype.verify = function verifyMethod (key, sig, enc) {
 
   this.end()
   var hash = this._hash.digest()
-  return verify(sig, Buffer.concat([this._tag, hash]), key, this._signType)
+  return verify(sig, hash, key, this._signType, this._tag)
 }
 
 function createSign (algorithm) {

browser/sign.js

@@ -6,18 +6,19 @@ var BN = require('bn.js')
 var parseKeys = require('parse-asn1')
 var curves = require('./curves.json')
 
-function sign (hash, key, hashType, signType) {
+function sign (hash, key, hashType, signType, tag) {
   var priv = parseKeys(key)
   if (priv.curve) {
-    if (signType !== 'ecdsa') throw new Error('wrong private key type')
+    // rsa keys can be interpreted as ecdsa ones in openssl
+    if (signType !== 'ecdsa' && signType !== 'ecdsa/rsa') throw new Error('wrong private key type')
     return ecSign(hash, priv)
   } else if (priv.type === 'dsa') {
     if (signType !== 'dsa') throw new Error('wrong private key type')
     return dsaSign(hash, priv, hashType)
   } else {
-    if (signType !== 'rsa') throw new Error('wrong private key type')
+    if (signType !== 'rsa' && signType !== 'ecdsa/rsa') throw new Error('wrong private key type')
   }
-
+  hash = Buffer.concat([tag, hash])
   var len = priv.modulus.byteLength()
   var pad = [ 0, 1 ]
   while (hash.length + pad.length + 1 < len) pad.push(0xff)

browser/verify.js

@@ -4,17 +4,19 @@ var EC = require('elliptic').ec
 var parseKeys = require('parse-asn1')
 var curves = require('./curves.json')
 
-function verify (sig, hash, key, signType) {
+function verify (sig, hash, key, signType, tag) {
   var pub = parseKeys(key)
   if (pub.type === 'ec') {
-    if (signType !== 'ecdsa') throw new Error('wrong public key type')
+    // rsa keys can be interpreted as ecdsa ones in openssl
+    if (signType !== 'ecdsa' && signType !== 'ecdsa/rsa') throw new Error('wrong public key type')
     return ecVerify(sig, hash, pub)
   } else if (pub.type === 'dsa') {
     if (signType !== 'dsa') throw new Error('wrong public key type')
     return dsaVerify(sig, hash, pub)
   } else {
-    if (signType !== 'rsa') throw new Error('wrong public key type')
+    if (signType !== 'rsa' && signType !== 'ecdsa/rsa') throw new Error('wrong public key type')
   }
+  hash = Buffer.concat([tag, hash])
   var len = pub.modulus.byteLength()
   var pad = [ 1 ]
   var padNum = 0

test/index.js

@@ -79,6 +79,26 @@ fixtures.valid.ec.forEach(function (f) {
 
     t.end()
   })
+  if (f.scheme !== 'DSA' && f.scheme.toLowerCase().indexOf('dsa') === -1) {
+    test(f.message + ' named rsa through', function (t) {
+      var scheme = 'RSA-' + f.scheme.toUpperCase()
+      var nSign = nCrypto.createSign(scheme)
+      var bSign = bCrypto.createSign(scheme)
+
+      var bSig = bSign.update(message).sign(priv)
+      var nSig = nSign.update(message).sign(priv)
+      t.notEqual(bSig.toString('hex'), nSig.toString('hex'), 'not equal sigs')
+      t.equals(bSig.toString('hex'), f.signature, 'sig is determanistic')
+
+      var nVer = nCrypto.createVerify(f.scheme)
+      t.ok(nVer.update(message).verify(pub, bSig), 'node validate browser sig')
+
+      var bVer = bCrypto.createVerify(f.scheme)
+      t.ok(bVer.update(message).verify(pub, nSig), 'browser validate node sig')
+
+      t.end()
+    })
+  }
 })
 
 fixtures.valid.kvectors.forEach(function (f) {