add support for calling ECDSA signatures RSA signatures, cuz node allows it #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to go ahead and merge/publish this latter if nobody objects |
dcousens
reviewed
Nov 29, 2016
| @@ -63,6 +63,7 @@ fixtures.valid.ec.forEach(function (f) { | |||
| } | |||
|
|
|||
| test(f.message, function (t) { | |||
| console.log(f.scheme) | |||
dcousens
reviewed
Nov 29, 2016
| if (f.scheme !== 'DSA' && f.scheme.toLowerCase().indexOf('dsa') === -1) { | ||
| test(f.message + ' named rsa through', function (t) { | ||
| var scheme = 'RSA-' + f.scheme.toUpperCase() | ||
| console.log(scheme) |
dcousens
reviewed
Nov 29, 2016
| } | ||
|
|
||
| hash = Buffer.concat([tag, hash]) |
There was a problem hiding this comment.
why did you move this in?
Doesn't really matter I suppose, just seems odd
There was a problem hiding this comment.
ah it's because we only need the tag when it is an rsa key NOT when it's an ecdsa key so since we can't tell based on the signature type asked for we have to do it based on what rutine they are using, so this code path only is executed for rsa signatures never (ec)dsa
dcousens
reviewed
Nov 29, 2016
| var priv = parseKeys(key) | ||
| if (priv.curve) { | ||
| if (signType !== 'ecdsa') throw new Error('wrong private key type') |
There was a problem hiding this comment.
Could you add a comment here about why this is the case?
ecdsa/rsa seems strange
|
LGTM otherwise |
|
Ok will update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #32