[WIP] 0.6.0 update DRAFT WIP 1 #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0947e7.
By these changes, developer's library can read android plugin version and react-native version of root project
- remove ignored react-native init options - factor const execCommand string into its own line - add react-native init command info to logging
Co-authored-by: Christopher J. Brody <chris@brody.consulting> Co-authored-by: Timo Jääskeläinen <timojaask@users.noreply.github.com>
for iOS & Android (with one TODO comment restored for iOS)
added 4 commits
July 10, 2019 21:22
defaults to react-native@0.59 for now (use exampleReactNativeVersion="react-native@latest" to generate example with the most current react-native release)
for the sake of consistency with React Native 0.59
you added some changes on my PR (the added backslashes) but you didn't change the android gradle version to |
added 2 commits
July 11, 2019 17:56
brody4hire
force-pushed
the
0.6.0-update-dev-wip1
branch
from
ae0231d to
b89063d
Compare
brody4hire
force-pushed
the
0.6.0-update-dev-wip1
branch
from
b89063d to
6d9bf13
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but keeping the Android Tools plugin version at3.3.2for nowTested on Android & iOS, with and without
--viewoption, on React Native versions 0.57, 0.58, and 0.59. (Known issues #28 & #29 were already raised concerning RN 0.60).TODO items:
npm i -g)test with RN 0.58, as needed to work with React Native Windows current .NET (see Known issues with out-of-tree Windows platform support #23)TBD what about RN 0.57? (now tested OK on RN 0.57)