Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous IO 👯‍♀️👯‍♂️ #39

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Asynchronous IO 👯‍♀️👯‍♂️ #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4874d77
BRISK ASYNC WIP
rauanmayemir Jan 26, 2019
ef71aa2
Make two threaded applications behave correctly
wokalski Jan 27, 2019
5b988e4
Fix segmentation fault if delegate callbacks are not set
rauanmayemir Jan 28, 2019
cd9a976
Add updates from review feedback
rauanmayemir Jan 28, 2019
10b6073
Improve retaining and releasing views
rauanmayemir Jan 28, 2019
cd6ae2c
Fix GCD and NSWindow C binding crashes
wokalski Jan 29, 2019
a543c0e
Use noalloc version for Window.contentHeight
wokalski Jan 29, 2019
cb8b03e
Mark OutputTree as not dirty after performing flushPendingUpdates
wokalski Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use noalloc version for Window.contentHeight
  • Loading branch information
@wokalski
wokalski committed Jan 29, 2019
commit a543c0eee557db3466cfa929f0777fe9e8d8b5fa
5 changes: 3 additions & 2 deletions renderer-macos/lib/bindings/BriskWindow.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ external _NSWindow_setContentView: (window, view) => unit =
[@noalloc]
external _NSWindow_contentWidth: window => [@unboxed] float =
"ml_NSWindow_contentWidth" "ml_NSWindow_contentWidth";
external _NSWindow_contentHeight: window => float =
"ml_NSWindow_contentHeight_bc" "ml_NSWindow_contentHeight_bc";
[@noalloc]
external _NSWindow_contentHeight: window => [@unboxed] float =
"ml_NSWindow_contentHeight_bc" "ml_NSWindow_contentHeight";
external setOnWindowDidResize: (window, unit => unit) => unit =
"ml_NSWindow_setOnWindowDidResize";

Expand Down
10 changes: 6 additions & 4 deletions tester-macos/bin/app.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,20 +119,22 @@ let () = {
let view = BriskView.make();
let layoutNode =
makeLayoutNode(
~style=[width(Window.contentWidth(window)), height(Window.contentHeight(window))],
~style=[
width(Window.contentWidth(window)),
height(Window.contentHeight(window)),
],
view,
);
{Brisk.OutputTree.view, layoutNode};
};

Window.center(window);
Window.makeKeyAndOrderFront(window);
Window.setTitle((window), appName);
Window.setTitle(window, appName);
Window.setContentView(window, root.view);

Window.windowDidResize(window, _ => {
Window.windowDidResize(window, _ =>
Brisk.UI.setWindowHeight(Window.contentHeight(window))
}
);

Brisk.UI.renderAndMount(
Expand Down