Asynchronous IO 👯♀️👯♂️ #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauanmayemir
changed the title
wokalski
changed the title
wokalski
reviewed
Jan 28, 2019
rauanmayemir
commented
Jan 28, 2019
This helps to partially solve #41 and also removes `brisk_init` call.
wokalski
reviewed
Jan 28, 2019
|
There's a crash but I logged it separately in #44. |
wokalski
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a two threaded communication in brisk applications:
1). UI happens on the main thread
2). Logic happens on the background thread
So far, this only sleeps for 1 second before changing state, but we need to add some examples of HTTP requests. This also closes #36 and gives a way to implement #33.
Huge thanks to @aantron for helping us understand how
Lwtworks internally and making this possible.