Fixed the Settings Menu #3044
Merged
Fixed the Settings Menu #3044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
philrz
approved these changes
Apr 10, 2024
Contributor
|
@jameskerr and I had an offline discussion about my first impressions upon reviewing the new design in this PR. At first I was thrown by the lack of an explicit Save button like we used to have in the old Settings menu. The one thing this loses us is the ability to start making a change but then hit Esc or click Cancel to back out and leave the prior setting intact. However, after a quick review of some modern tools like Slack and VSCode, I could see that the approach used here where changes are effectively committed immediately is now more in vogue. I've quickly adjusted to the new paradigm and I'm optimistic our users will as well. |
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few files change. 🤣
I redid the settings modal, and updated all form elements in the app. Hopefully for the last time.
And the bug about the brimcap file is fixed.
Fixes #2949