Native esbuild integration, defaults switched to esbuild/postcss #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-api-pr-461.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6fjfk9g7hp517qj6flg. |
|
Your Render PR Server URL is https://bridgetown-beta-pr-461.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c6fjfkpg7hp517qj6fp0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
BIG CHANGE: after some reflection, I asked myself why—in a world where esbuild and PostCSS are good to go—would we continue to ship with Webpack and Sass as the default? I wouldn't use those as my defaults for any new projects. So this PR switches gears and now esbuild+PostCSS is the default, and you can optionally choose Webpack instead and also optionally choose Sass. This feels right for the year 2022. Sass is opinionated and only necessary if you know why you need it. Same thing for Webpack as well IMHO.
If I hear strong feedback to the contrary, always open to changing my mind. 🙂