Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the option to use esbuild #94

Closed
KonnorRogers opened this issue Jul 8, 2020 · 4 comments · Fixed by #461
Closed

feat: add the option to use esbuild #94

KonnorRogers opened this issue Jul 8, 2020 · 4 comments · Fixed by #461
Labels
enhancement New feature or request high priority This should get addressed as soon as possible. process Improve the development process for the repo
Milestone

Comments

@KonnorRogers
Copy link
Member

KonnorRogers commented Jul 8, 2020

Update by @jaredcwhite: focusing on esbuild initially, see below…


Add a flag to use Snowpack and possibly other bundlers instead of webpack.

bridgetown new <dir> --bundler=snowpack

I'm thinking something like the syntax above.

Thoughts?

@KonnorRogers KonnorRogers added enhancement New feature or request process Improve the development process for the repo labels Jul 8, 2020
@jaredcwhite
Copy link
Member

@ParamagicDev I like the concept…I'm not sure bundler by itself is quite the right term, it might be confusing as there's also Ruby Bundler. Maybe --frontend-bundler or something like that.

@KonnorRogers KonnorRogers reopened this Jul 10, 2020
@jaredcwhite jaredcwhite added the high priority This should get addressed as soon as possible. label Dec 19, 2020
@jaredcwhite
Copy link
Member

Starting to get excited about Snowpack/Skypack possibilities. Thinking this would be good to prioritize in Q1 2021. Also another opt idea: --frontend-builder=webpack, --frontend-builder=snowpack

@ayushn21
Copy link
Member

Given that we have the --use-postcss option in main now and with the choice of frontend builders soon to come; I wonder if it's worth considering an interactive mode for bridgetown new? I know the number of options we have right now is pretty small, but as it gets bigger, it'll likely provide a better developer experience I reckon.

As a developer, I won't have to go through the docs and understsand which options are available to me beforehand. I could just run bridgetown new and be asked "How would you like to process your CSS?" and "Which frontend bundler would you like to use?".

I have no idea about the amount of work required for an interactive new command though and not completely sure if it's worth it at this point but thought I'd ask the question!!

@jaredcwhite jaredcwhite changed the title feat: add the option to use other bundlers feat: add the option to use esbuild Sep 29, 2021
@jaredcwhite
Copy link
Member

I have a bit of experience now using esbuild, and with the recent update in Rails 7 to support esbuild specifically, I think it makes sense to focus on that for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority This should get addressed as soon as possible. process Improve the development process for the repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants