Fix: Minimal changes needed to make the example build and run on macOS#7
Merged
brenocq merged 3 commits intobrenocq:devfrom Dec 24, 2024
Merged
Fix: Minimal changes needed to make the example build and run on macOS#7brenocq merged 3 commits intobrenocq:devfrom
brenocq merged 3 commits intobrenocq:devfrom
Conversation
This was referenced Dec 18, 2024
Contributor
Author
|
Ok, I just tested the alternative to not include IMHO this is the better solution. From your comment it sounds like you want to make that change anyway: ...once that change lands I can remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to make the example build and run on current Macs:
implot3d.cppwithstd::prefix throw compilation errors, fixed by adding a#include <cmath>at the top (I wonder though if it is better to just remove thestd::prefix. Let me know if I should try that instead.implot3d_demo.cppwherestd::sqrt()is called, here I simply removed thestd::prefix though (since the other math calls in that source file don't use the prefix either)This was enough to make the example build, but then running failed with an error message that the GL context couldn't be created. This is fixed by changing the GL context version to 3.2 and enabling the
GLFW_OPENGL_FORWARD_COMPATGLFW window hint.Result:
NOTE: I haven't tested those changes on any other platform.