Add a github-ci script to test compilation on Linux, macOS and Windows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenocq
added
type:chore
brenocq
changed the title
brenocq
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
@floooh Thank you so much for taking the initiative to write the GitHub CI script! It looks amazing, and I honestly can't think of a way to simplify it further. I'll go ahead and merge it now – I'll also add the badges to the README.
brenocq
added
status:done
|
Hey @floooh! The README has now been updated with the build badges! I had to split the workflow into multiple files to get one badge per operating system, but it turned out pretty cool. If you feel like contributing more, feel free to pick a feature from here and leave a comment. There’s tons of work to do kkkkkk. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build fails on macOS and Windows. Both builds are most likely fixed after applying my other PR (#7) - e.g. the Windows build also fails because of the
std::prefix for math functions....in addition there's a lot of warnings in MSVC about double/float conversions which might be worth fixing:
'initializing': conversion from 'double' to 'float', possible loss of dataExample CI run in my fork:
https://github.com/floooh/implot3d/actions/runs/12393862255