Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HangoutsExtension] Remove hangouts extension #24594

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

jagadeshjai
Copy link
Collaborator

@jagadeshjai jagadeshjai commented Jul 10, 2024

  • Disable hangouts extension by passing the buildflag via GN args.
  • Remove the option available for the same in setting page.

Resolves brave/brave-browser#39660

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade scenario

Snippet courtesy of https://fedi.simonwillison.net/@simon/112757810519145581

  1. Have a version of Brave BEFORE this change - clean profile.
  2. Visit brave://settings/extensions
  3. Hangouts should be enabled by default. Toggle it to OFF. Then back to ON.
  4. Upgrade to a version of Brave which has this fix
  5. Verify Hangouts is no longer in brave://settings/extensions
  6. Visit brave://extensions-internals/
  7. Verify nkeimhogjdpnpccoofpliimaahmaaome is no longer there
  8. Visit https://google.com
  9. Open the dev tools
  10. In the console, paste in the following and hit Enter:
    chrome.runtime.sendMessage(
      "nkeimhogjdpnpccoofpliimaahmaaome",
      { method: "cpu.getInfo" },
      (response) => {
        console.log(JSON.stringify(response, null, 2));
      },
    );
    
  11. There should be an error shown in console and no information should show.

Fresh profile

Same as Upgrade scenario - but skip to step 5

@jagadeshjai jagadeshjai changed the title [HangoutsExtension] Remove hangouts extension by passing the buildflag via GN args. [HangoutsExtension] Remove hangouts extension Jul 10, 2024
@jagadeshjai jagadeshjai force-pushed the remove__hangouts_extension branch from 9524281 to 73ed47d Compare July 10, 2024 21:06
@bsclifton bsclifton marked this pull request as ready for review July 11, 2024 06:55
@bsclifton bsclifton requested review from a team as code owners July 11, 2024 06:55
@bsclifton bsclifton force-pushed the remove__hangouts_extension branch from 6b1f4ac to d22460a Compare July 11, 2024 07:16
@bsclifton bsclifton force-pushed the remove__hangouts_extension branch from d22460a to 8393fce Compare July 11, 2024 07:20
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; verified it works using some of the steps from test plan in #24583

String reviewers changes LGTM ++

CI run happening now with #24599

@jagadeshjai
Copy link
Collaborator Author

@rebron Could you please confirm whether we need to show a InfoBar message or similar to convey the users for removing this option.

@jagadeshjai jagadeshjai force-pushed the remove__hangouts_extension branch from f5cb0a4 to 772901c Compare July 11, 2024 17:18
@bsclifton
Copy link
Member

@jagadeshjai I checked with @rebron - no infobar needed! 😄

@bsclifton
Copy link
Member

Everything here looks good to go!

@goodov it's ready for your re-review after @jagadeshjai added the test case 😄👍

Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with few nits

@@ -61,6 +61,7 @@ inline constexpr char kShieldsStatsBadgeVisible[] =
inline constexpr char kAdControlType[] = "brave.ad_default";
inline constexpr char kGoogleLoginControlType[] = "brave.google_login_default";
inline constexpr char kWebTorrentEnabled[] = "brave.webtorrent_enabled";
// Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is needed here. right now it looks like everything below is deprecated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goodov How about adding right side of the definition?

Suggested change
// Deprecated
inline constexpr char kWebTorrentEnabled[] = "brave.webtorrent_enabled"; // Deprecated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webtorrent is OK; it's the one below that is deprecated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes, I just wanted to show it with example 😆

@bsclifton bsclifton merged commit 69c7272 into brave:master Jul 12, 2024
18 of 19 checks passed
@bsclifton bsclifton added this to the 1.69.x - Nightly milestone Jul 12, 2024
@jagadeshjai jagadeshjai deleted the remove__hangouts_extension branch July 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hangouts component
3 participants