Skip to content

Commit

Permalink
Updated preference removal to be migration / clear
Browse files Browse the repository at this point in the history
  • Loading branch information
bsclifton committed Jul 11, 2024
1 parent e3da4e1 commit 8393fce
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions browser/brave_profile_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ void RegisterProfilePrefsForMigration(

// Added 2024-05
ipfs::RegisterDeprecatedIpfsPrefs(registry);

// Added 2024-07
registry->RegisterBooleanPref(kHangoutsEnabled, false);
}

void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
Expand Down
3 changes: 3 additions & 0 deletions chromium_src/chrome/browser/prefs/browser_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ void MigrateObsoleteProfilePrefs(PrefService* profile_prefs,
// Added 2024-05
ipfs::ClearDeprecatedIpfsPrefs(profile_prefs);

// Added 2024-07
profile_prefs->ClearPref(kHangoutsEnabled);

// END_MIGRATE_OBSOLETE_PROFILE_PREFS
}

Expand Down
2 changes: 2 additions & 0 deletions components/constants/pref_names.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ inline constexpr char kShieldsStatsBadgeVisible[] =
inline constexpr char kAdControlType[] = "brave.ad_default";
inline constexpr char kGoogleLoginControlType[] = "brave.google_login_default";
inline constexpr char kWebTorrentEnabled[] = "brave.webtorrent_enabled";
// Deprecated
inline constexpr char kHangoutsEnabled[] = "brave.hangouts_enabled";
inline constexpr char kNewTabPageShowClock[] = "brave.new_tab_page.show_clock";
inline constexpr char kNewTabPageClockFormat[] =
"brave.new_tab_page.clock_format";
Expand Down

0 comments on commit 8393fce

Please sign in to comment.