[CLOSED] Cleaner fix for LiveDevMultiBrowser infinite loop

[core-ai-bot]

Issue by peterflynn
Wednesday Dec 17, 2014 at 18:44 GMT
Originally opened as adobe/brackets#10207

---

This is for #10193. See discussion here for context: adobe/brackets#10192 (comment).

Move shared code into FileUtils (with unit tests) to minimize diff in the _getInitialDocFromCurrent() code that is duplicated between the two Live Preview impls.

Also...

• fixes an unhit edge case in getParentFolder() (now getParentDirectory()) that behaves differently across platforms
• removes duplicate copy of getFilenameWithoutExtension() in LiveDevelopment.js (copy in FileUtils was identical)
• add/fix some unit tests for two existing FileUtils APIs

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/10207/commits

[core-ai-bot]

Comment by busykai
Wednesday Dec 17, 2014 at 18:56 GMT

---

LGTM, just the comment on the function name and nit on the suite name.

[core-ai-bot]

Comment by dsrw
Wednesday Dec 17, 2014 at 19:03 GMT

---

Works for me. Thanks a lot@peterflynn and@busykai. I'll close my PR.

[core-ai-bot]

Comment by peterflynn
Wednesday Dec 17, 2014 at 19:09 GMT

---

@busykai Oops, sorry -- somehow I accidentally pushed a draft that didn't have my final changes committed. The actual changes in my real commit (should be up there now) doesn't have either of the issues you mentioned. (I used the API name getParentPath() to stay analogous with FleSystemEntry.parentPath, as well as to indicate a string return value as you mentioned).

[core-ai-bot]

Comment by busykai
Wednesday Dec 17, 2014 at 19:11 GMT

---

@peterflynn, thanks! This looks good to me. Just some manual testing and will merge it. The tests are clean.

[core-ai-bot]

Comment by peterflynn
Wednesday Dec 17, 2014 at 19:11 GMT

---

Excellent, thanks!

[core-ai-bot]

Comment by busykai
Wednesday Dec 17, 2014 at 19:20 GMT

---

Merging.