[CLOSED] remove predefined values from cubic-bezier()

[core-ai-bot]

Issue by myakura
Wednesday Oct 07, 2015 at 06:15 GMT
Originally opened as adobe/brackets#11786

---

looks like adobe/brackets@1295cfe#diff-0 unintentionally introduced these predef values. so taking them out.

---

myakura included the following code: https://github.com/adobe/brackets/pull/11786/commits

[core-ai-bot]

Comment by abose
Wednesday Oct 07, 2015 at 08:50 GMT

---

Thanks@myakura for contributing to brackets.
The Contributor License Agreement should be signed before we can accept the change.

[core-ai-bot]

Comment by nethip
Wednesday Oct 07, 2015 at 11:18 GMT

---

@redmunds Would you mind reviewing this change?

[core-ai-bot]

Comment by petetnt
Wednesday Oct 07, 2015 at 11:24 GMT

---

I think those values are be intentional: the values are equivalent to ease-in-out, which is often used* as the default value for cubic-bezier curves because it nicely shows what it's meant for. Other default would be equal to linear (0,0,1,1), which isn't that nice IMO.

• citation needed, might just be my own opinion.

[core-ai-bot]

Comment by nethip
Wednesday Oct 07, 2015 at 11:26 GMT

---

Thanks@petetnt for quickly jumping in and trying to analyze this 👍

[core-ai-bot]

Comment by redmunds
Wednesday Oct 07, 2015 at 16:11 GMT

---

@nethip Yes,@petetnt is correct about the original reason for using predefined values. But, I think that@MarcelGerber fixed it so that cubic-bezier() will now give the same result, so predefined values may no longer be necessary.

[core-ai-bot]

Comment by myakura
Friday Oct 09, 2015 at 00:29 GMT

---

@abose thx. signed!

[core-ai-bot]

Comment by abose
Thursday Nov 19, 2015 at 05:35 GMT

---

Merged for 1.6. Thanks@myakura