Skip to content

[CLOSED] Monkeypatch CodeMirror for sprint 36 to include latest xml mode #5840

@core-ai-bot

Description

@core-ai-bot

Issue by njx
Thursday Jan 09, 2014 at 00:34 GMT
Originally opened as adobe/brackets#6421


@RaymondLim

This points the Brackets CM submodule SHA at the monkeypatch-sprint36 branch in the adobe/CodeMirror2 repo: https://github.com/adobe/CodeMirror2/tree/monkeypatch-sprint36. The only change in that branch from the SHA we'd previously merged (in #6268) is a commit that pulls in the latest xml mode from CodeMirror master. In addition to the fix for #6400, the latest xml mode fixes a bug in indentation after open tags that span multiple lines, and the changes looked reasonably harmless, so I thought it made sense to go ahead and just pull it in instead of monkeypatching just the fix for #6400.

This also re-enables the HTML code hints unit test that was failing. I ran all the unit tests (including this one) and they passed.


njx included the following code: https://github.com/adobe/brackets/pull/6421/commits

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions