This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Monkeypatch CodeMirror for sprint 36 to include latest xml mode #6421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Jan 9, 2014
Monkeypatch CodeMirror for sprint 36 to include latest xml mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RaymondLim
This points the Brackets CM submodule SHA at the
monkeypatch-sprint36branch in the adobe/CodeMirror2 repo: https://github.com/adobe/CodeMirror2/tree/monkeypatch-sprint36. The only change in that branch from the SHA we'd previously merged (in #6268) is a commit that pulls in the latest xml mode from CodeMirror master. In addition to the fix for #6400, the latest xml mode fixes a bug in indentation after open tags that span multiple lines, and the changes looked reasonably harmless, so I thought it made sense to go ahead and just pull it in instead of monkeypatching just the fix for #6400.This also re-enables the HTML code hints unit test that was failing. I ran all the unit tests (including this one) and they passed.