This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Use nodenv version-name in shell helper function #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nodenv version` includes a description of how the version was selected:
$ nodenv version
5.0.0 (set by /opt/boxen/nodenv/version)
`nodenv version-name` prints the version number on its own:
$ nodenv version-name
5.0.0
Since the current_node function is intended to be used "in shell prompts
and the like", the second shorter form is more appropriate.
Contributor
You are correct. Thanks for making a more robust fix. |
blackjid
added a commit
that referenced
this pull request
Jan 4, 2016
Use nodenv version-name in shell helper function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodenv versionincludes a description of how the version was selected:nodenv version-nameprints the version number on its own:Since the
current_nodefunction is intended to be used "in shell prompts and the like", the second shorter form is more appropriate.This reverts the change from #56, which had the description:
It is, though; defined here: https://github.com/OiNutter/nodenv/blob/master/libexec/nodenv-version-name
I suspect @DanielWright was stuck using wfarr/nodenv, which doesn't provide
nodenv version-name: https://github.com/wfarr/nodenv/tree/master/libexec...and I suspect that happened because of a bug in boxen/puppet-repository, which meant refs weren't updated when the remote was changed: boxen/puppet-repository#16