Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

support 0.8.2 meteor release#81

Merged
boundsj merged 3 commits intoboundsj:masterfrom
mikey0000:0.8.2
Jul 1, 2014
Merged

support 0.8.2 meteor release#81
boundsj merged 3 commits intoboundsj:masterfrom
mikey0000:0.8.2

Conversation

@mikey0000
Copy link
Collaborator

I've removed srp and the openssl libs and am using the built in functions for sha256 hashing for the passwords, supports heartbeats, supports versions which meteor now rejects the connection if isn't present.

Michael Arthur and others added 3 commits May 8, 2014 17:32
@boundsj
Copy link
Owner

boundsj commented Jun 26, 2014

awesome. i can't wait to review, will do ASAP. thank you so much!

@mikey0000
Copy link
Collaborator Author

@boundsj no problems I'm honestly really happy to be contributing to this.

@allaire
Copy link
Contributor

allaire commented Jun 30, 2014

👍 Good job @mikey0000! I spotted a couple place where it was missing spaces around = and in the method definition -(void). It would be great to follow the same coding style 😃

@boundsj
Copy link
Owner

boundsj commented Jun 30, 2014

@mikey0000 @allaire I am working on this, sorry for the delay. I'm updating (mostly deleting) specs to match the new implementation and also changing some of the documentation. I am also playing whitespace police to bring the new code into alignment with the existing style.

Functionally though, everything looks great. Thanks again.

@allaire
Copy link
Contributor

allaire commented Jun 30, 2014

Ok, keep us posted in this PR @boundsj!

@mikey0000
Copy link
Collaborator Author

Haha, sorry guys, to be honest I rushed the changes at work, I'll make sure to check my whitespacing/styling next time. Glad its passed your inspection @boundsj

@boundsj
Copy link
Owner

boundsj commented Jul 1, 2014

This has been merged and a follow up commit made 380881f to fix several issues.

Most importantly, this commit comment 380881f#commitcomment-6850562 highlights some key missing logic that also needed to be ported over for the system to be able to function past initial login without crashing on many types of subsequent interactions with the meteor server.

Any and all are welcome to test against the latest commit to master and any bug reports are welcome.

This commit updates all cedar specs and the example todo list application and, in my testing, things look pretty solid (until they change auth again).

Thanks again @mikey0000 !!!

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants