support 0.8.2 meteor release#81
Conversation
… clients connect without this
… and creating sha256 hash of password for non-https connections
|
awesome. i can't wait to review, will do ASAP. thank you so much! |
|
@boundsj no problems I'm honestly really happy to be contributing to this. |
|
👍 Good job @mikey0000! I spotted a couple place where it was missing spaces around |
|
@mikey0000 @allaire I am working on this, sorry for the delay. I'm updating (mostly deleting) specs to match the new implementation and also changing some of the documentation. I am also playing whitespace police to bring the new code into alignment with the existing style. Functionally though, everything looks great. Thanks again. |
|
Ok, keep us posted in this PR @boundsj! |
|
Haha, sorry guys, to be honest I rushed the changes at work, I'll make sure to check my whitespacing/styling next time. Glad its passed your inspection @boundsj |
|
This has been merged and a follow up commit made 380881f to fix several issues. Most importantly, this commit comment 380881f#commitcomment-6850562 highlights some key missing logic that also needed to be ported over for the system to be able to function past initial login without crashing on many types of subsequent interactions with the meteor server. Any and all are welcome to test against the latest commit to master and any bug reports are welcome. This commit updates all cedar specs and the example todo list application and, in my testing, things look pretty solid (until they change auth again). Thanks again @mikey0000 !!! 👏 |
I've removed srp and the openssl libs and am using the built in functions for sha256 hashing for the passwords, supports heartbeats, supports versions which meteor now rejects the connection if isn't present.