-
Notifications
You must be signed in to change notification settings - Fork 27
Metal: Add metal k8s resource provider #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmmm dependency mis/match? CI/CD failed with an openssh build failure:
|
|
I added a pr #774 to update the rustc version to align with the Bottlerocket SDK. |
webern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great but we need documentation that describes what this is, how it works, that it uses EKS-A and CAPI, that it needs a pre-existing management cluster, etc.
| EKS_RESOURCE_AGENT_IMAGE_URI = { value = "${AGENT_IMAGE_REGISTRY}/eks-resource-agent:v${AGENT_IMAGE_VERSION}", condition = { env_not_set = ["EKS_RESOURCE_AGENT_IMAGE_URI"] } } | ||
| VSPHERE_K8S_CLUSTER_RESOURCE_AGENT_IMAGE_URI = { value = "${AGENT_IMAGE_REGISTRY}/vsphere-k8s-cluster-resource-agent:v${AGENT_IMAGE_VERSION}", condition = { env_not_set = ["VSPHERE_K8S_CLUSTER_RESOURCE_AGENT_IMAGE_URI"] } } | ||
| VSPHERE_VM_RESOURCE_AGENT_IMAGE_URI = { value = "${AGENT_IMAGE_REGISTRY}/vsphere-vm-resource-agent:v${AGENT_IMAGE_VERSION}", condition = { env_not_set = ["VSPHERE_VM_RESOURCE_AGENT_IMAGE_URI"] } } | ||
| METAL_K8S_CLUSTER_RESOURCE_AGENT_IMAGE_URI = { value = "${AGENT_IMAGE_REGISTRY}/metal-k8s-cluster-resource-agent:v${AGENT_IMAGE_VERSION}", condition = { env_not_set = ["METAL_K8S_CLUSTER_RESOURCE_AGENT_IMAGE_URI"] } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not asking for it to change now but I regret the formatting of this makefile. I generally like to spend currency in newlines to make things easier to read.
|
^ added a doc comment to the metal resource provider explaining prerequisites and how the agent works. |
mjsterckx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be rebased now that #772 is merged.
mjsterckx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number:
#415
Description of changes:
This adds the
metal-k8s-cluster-resource-agentwhich takes and encoded management cluster kubeconfig, hardware csv, and eks anywhere config and creates a metal k8s cluster and registers all machines to ssm.Testing done:
Created the test manifest with
cargo make create metal-sonobuoy-test.Applied the manifest with
cli run file <>Verified that the sonobuoy test passed, and the resource destruction was performed correctly.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.