samples: added variable to makefile to get agent images from single repo #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Feb 22, 2023
Contributor
stmcginnis
left a comment
stmcginnis
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Added two variables to the samples makefile:
SINGLE_IMAGE_REPOandAGENT_IMAGE_REPOwill ensure that all agent images are retrieved from${AGENT_IMAGE_REGISTRY}/${AGENT_IMAGE_REPO}.Testing done:
Generated and ran all tests in the
eksfolder after settingSINGLE_IMAGE_REPOto "true" and pointingAGENT_IMAGE_REPOto a private repo containing all agent images.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.