Skip to content

fix(auth): warn on empty bearer token env var #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohan-patnaik wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(auth): warn on empty bearer token env var #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion botocore/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3630,7 +3630,14 @@ def get_token_from_environment(signing_name, environ=None):
if environ is None:
environ = os.environ
env_var = _get_bearer_env_var_name(signing_name)
return environ.get(env_var)
token = environ.get(env_var)
if token == '':
logger.warning(
"%s is set to an empty value; requests using bearer "
"authentication may fail",
env_var,
)
return token


def _get_bearer_env_var_name(signing_name):
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import copy
import datetime
import io
import logging
import operator
import os
import shutil
Expand Down Expand Up @@ -3726,6 +3727,14 @@ def test_get_token_from_environment_returns_token(
assert get_token_from_environment(signing_name) == token


def test_get_token_from_environment_warns_for_empty_token(monkeypatch, caplog):
monkeypatch.setenv("AWS_BEARER_TOKEN_MY_SERVICE", "")
caplog.set_level(logging.WARNING, logger="botocore.utils")

assert get_token_from_environment("my-service") == ""
assert "AWS_BEARER_TOKEN_MY_SERVICE is set to an empty value" in caplog.text


@pytest.mark.parametrize(
"signing_name, env_var",
[
Expand Down