fix(auth): warn on empty bearer token env var#3713
Open
rohan-patnaik wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3603
Summary
This logs a warning when a bearer token environment variable is set to an empty string.
Why
An empty bearer token is still treated as configured today, which matches the current environment-variable behavior. The hard part for users is diagnosing it: requests can fail later with confusing service-side auth errors. This warning makes the bad configuration visible without changing token resolution semantics.
Test plan
.venv/bin/python -m pytest tests/unit/test_utils.py::test_get_token_from_environment_warns_for_empty_token tests/unit/test_utils.py::test_get_token_from_environment_returns_token tests/unit/test_utils.py::test_get_token_from_environment_returns_nonegit diff --check