templates: add parseTime func #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo3-l
changed the title
jo3-l
force-pushed
the
patch-4
branch
2 times, most recently
from
a5af798 to
9fc60d0
Compare
jo3-l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing time strings into time structs in custom commands has long been a pain point. This PR aims to fix this by exposing
time.ParseInLocationfor usage in CCs. I wasn't sure what restrictions this function should have internally - should the number of layouts if it's in the form of a string slice be restricted?I have tested this code on a selfhost and it appears to work fine.