templates: use reflection for parseTime

common/templates/general.go

@@ -999,31 +999,35 @@ func tmplParseTime(layouts interface{}, value string, optionalArgs ...string) (t
 	}
 
 	var parsed time.Time
-	switch l := layouts.(type) {
-	case []interface{}:
-		for _, layout := range l {
-			switch v := layout.(type) {
+
+	val := reflect.ValueOf(layouts)
+	switch val.Kind() {
+	case reflect.Slice, reflect.Array:
+		for i := 0; i < val.Len(); i++ {
+			switch layout := val.Index(i).Interface().(type) {
 			case string:
-				parsed, err = time.ParseInLocation(v, value, loc)
+				parsed, err = time.ParseInLocation(layout, value, loc)
 				if err != nil {
-					// when an error is returned, it implies the value does not match the layout
-					// as error recovery is not possible within custom commands, returning the error would be useless
+					// Error recovery is essentially impossible in CC, so throwing an error on invalid input would be useless
 					continue
 				}
+
 				return parsed, nil
 			default:
 				return time.Time{}, errors.New("can't parse time with non-string layout")
 			}
 		}
+
 		return time.Time{}, nil
-	case string:
-		parsed, err = time.ParseInLocation(l, value, loc)
+	case reflect.String:
+		parsed, err = time.ParseInLocation(val.Interface().(string), value, loc)
 		if err != nil {
 			return time.Time{}, nil
 		}
+
 		return parsed, nil
 	default:
-		return time.Time{}, errors.New("argument provided to parseTime() was neither a string slice nor a string")
+		return time.Time{}, errors.New("argument passed to parseTime() was neither a string slice nor a string")
 	}
 }