Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to fix some warnings #945

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Minor fixes to fix some warnings #945

merged 4 commits into from
Nov 30, 2021

Conversation

bricerebsamen
Copy link
Contributor

When I was building gtsam with my build system and my compiler flags I got a bunch or errors:

  • return type should not be const static const double fn() --> static double fn()
  • missing shared_ptr includes in 2 files
  • missing arg in initializer list when initializing ParseMeasurement<Pose2>

I also added *.swp to .gitignore to ignore vim swp files.

varunagrawal
varunagrawal approved these changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit 8efaf26 into borglab:develop Nov 30, 2021
@bricerebsamen bricerebsamen deleted the fix_build branch November 30, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bricerebsamen @varunagrawal