Enable pickling #942
Merged
Enable pickling #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
requested changes
Nov 29, 2021
|
@dellaert added details on pickling with the wrapper. |
dellaert
approved these changes
Nov 29, 2021
|
It is. I noticed this exact problem when making this PR, but this requires a change to the wrapper. I can do it over the next week after higher priority items have been completed. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pickling so we can deep copy a bunch of things in the Python wrapper.
The wrapper expects declaration of the
picklemethod in the interface file and will use the underlyingserializemethod of the class. The wrapper has had this feature for a while, but the classes updated in this PR didn't have the pickling enabled.