Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FastDefaultAllocator for Values to adhere allocation compile flags #936

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Use FastDefaultAllocator for Values to adhere allocation compile flags #936

merged 1 commit into from
Nov 22, 2021

Conversation

beetleskin
Copy link

Fixes #935

@ProfFan ProfFan self-requested a review November 22, 2021 16:56
@ProfFan
Copy link
Collaborator

ProfFan commented Nov 22, 2021

Thanks @beetleskin !

@ProfFan ProfFan mentioned this pull request Nov 22, 2021
Closed
3 tasks
@beetleskin
Copy link
Author

Not an expert on your CI, but the fails look like induced by the CI itself.

@varunagrawal varunagrawal merged commit 2764f44 into borglab:develop Nov 22, 2021
@beetleskin beetleskin deleted the fix/use_fastdefaultallocator_for_values branch December 2, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Values memory allocation does not adhere GTSAM_DEFAULT_ALLOCATOR flag
3 participants
@beetleskin @ProfFan @varunagrawal