Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecations #934

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Add deprecations #934

merged 3 commits into from
Nov 23, 2021

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Nov 21, 2021

varunagrawal
varunagrawal requested changes Nov 21, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

gtsam/discrete/DiscreteConditional.cpp Outdated Show resolved Hide resolved
gtsam/discrete/Potentials.cpp Outdated Show resolved Hide resolved
varunagrawal
varunagrawal approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ProfFan ProfFan merged commit 58d4c05 into develop Nov 23, 2021
@ProfFan ProfFan deleted the feature/deprecation_macro branch November 23, 2021 00:23
@varunagrawal varunagrawal mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProfFan @varunagrawal