Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap KeyVector methods #932

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Wrap KeyVector methods #932

merged 1 commit into from
Nov 19, 2021

Conversation

varunagrawal
Copy link
Collaborator

The title. This is needed for MHS.

We're also going to need to publish the latest version of the python package so that the CI can run successfully.

@varunagrawal varunagrawal added quick-review Quick and easy PR to review wrapper Related to the wrapper labels Nov 19, 2021
@varunagrawal varunagrawal self-assigned this Nov 19, 2021
@dellaert
Copy link
Member

The title. This is needed for MHS.

We're also going to need to publish the latest version of the python package so that the CI can run successfully.

Explain comment about CI, it should not depend on a python package

@varunagrawal
Copy link
Collaborator Author

The MHS CI pulls the GTSAM python package for efficiency rather than build the wrapper from scratch. If we wrap something new, that's not already available on PyPI and so we need to push the latest package to PyPI

@johnwlambert
Copy link
Contributor

The MHS CI pulls the GTSAM python package for efficiency rather than build the wrapper from scratch. If we wrap something new, that's not already available on PyPI and so we need to push the latest package to PyPI

Yeah our pypi version is ancient. What's our current versioning policy? Are we on 4.1 or 4.0.1?

@ProfFan
Copy link
Collaborator

ProfFan commented Nov 19, 2021

4.1 is still not released, but maybe we should push another pre release

@varunagrawal
Copy link
Collaborator Author

Then let's merge this and get to it?

@ProfFan ProfFan merged commit fa28bbb into develop Nov 19, 2021
@ProfFan ProfFan deleted the feature/keyVector-wrap branch November 19, 2021 16:24
@dellaert
Copy link
Member

The MHS CI pulls the GTSAM python package for efficiency rather than build the wrapper from scratch. If we wrap something new, that's not already available on PyPI and so we need to push the latest package to PyPI

OK, you should probably specify it won't affect GTSAM CI. This is a GTSAM PR.

@varunagrawal
Copy link
Collaborator Author

Gotcha. I mentioned this was needed for MHS but in my head I figured it was implied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-review Quick and easy PR to review wrapper Related to the wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants