Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup Python Examples #903

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Fixup Python Examples #903

merged 2 commits into from
Oct 23, 2021

Conversation

varunagrawal
Copy link
Collaborator

This PR puts all the example scripts inside main-guards aka if __name__ == "__main__" as well as applies formatting to them.

This will allow us to run stubgen to generate type annotations without it running the scripts.

@varunagrawal varunagrawal added the python Related to python wrapper label Oct 22, 2021
@varunagrawal varunagrawal self-assigned this Oct 22, 2021
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit c56579c into develop Oct 23, 2021
@varunagrawal varunagrawal deleted the feature/python-examples branch October 23, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to python wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants