Revert @acxz's TBB revert #901
Conversation
This reverts commit f819b1a.
|
If I remember correctly, wasn't the issue that a test would fail intermittently due to the lack of determinism in the concurrency? @acxz |
|
I think that is actually not related to this particular PR, but I could be wrong. Need more testing to be sure... |
|
I'm waiting for @acxz to make a note about the issue before I approve. |
| if ((${TBB_VERSION} VERSION_GREATER "2021.1") OR (${TBB_VERSION} VERSION_EQUAL "2021.1")) | ||
| message(FATAL_ERROR "TBB version greater than 2021.1 (oneTBB API) is not yet supported. Use an older version instead.") | ||
| endif() | ||
| # if ((${TBB_VERSION} VERSION_GREATER "2021.1") OR (${TBB_VERSION} VERSION_EQUAL "2021.1")) |
This was the only issue I personally encountered: #800 (comment) The issues that came up (#820) showed that the original PR was not a problem and as such I agree with @ProfFan this is safe to merge. As you mentioned we'll handle issues as they come up. |
|
Update on this PR: It seems to be the cause of the recent ILS errors in GTDynamics. By turning off TBB, the errors go away. @acxz can you take a look at this and help us understand why? You're probably the best at TBB amongst us. |
|
I'm afraid I don't really have the time to look at the GTDynamics issues right now. |
|
This isn't a GTDynamics issue, but the GTDynamics issue is a symptom of the issue with TBB :) |
I tested and didn't find any actual problem with the code by @acxz , so I think it's safe to revert.
Plus this allows building GTSAM with TBB 2021.x.