[CMake][Bugfix] Fixed matlab wrapper based on new project names #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Seems there is conflict and conversation with @jlblancoc so I'll let you approve, Jose :-) |
|
I checked it, and the proposed patch is already in develop, slightly differently. So this one could be closed, IMO. |
|
Yep. I checked develop and it works fine for me. Sorry for the delay in responding. Thanks a lot! |
varunagrawal
added a commit
that referenced
this pull request
Apr 17, 2021
b80bc63cf Merge pull request #90 from borglab/fix/tpl_dependency 015b12da5 Merge pull request #86 from borglab/feature/optionalargs 362851980 address review comments e461ca50e Merge pull request #89 from borglab/fix/template_iostream 2d413db57 add pybind cpp generation dependency on tpl file 79881c25e include pybind11 iostream for ostream_redirect in example tpl 5e8323c25 fix test fixture 95495726a Merge branch 'master' into feature/optionalargs 5af826840 clean up the _py_args_names method to reduce copy-pasta 844ff9229 add identifier parsing to _type c3adca7a4 remove extra spaces from Type repr 350b531d7 slight test improvement fd4f37578 cleaner default argument parsing 6013deacb overpowered default argument parsing rule dbcda0ea2 fix unit tests for __repr__ ref vs ptr 1c23c42e4 fix pointer vs const ref in __repr__ 9b40350f1 update matlab tests df7e9023c handle __repr__ with default arguments 092ef489b update pybind_wrapper for default arguments 3a2d7aa8a unit test default argument pybind 61a2b114e implement default argument parser c2b92ffec unit test for parsing default arguments git-subtree-dir: wrap git-subtree-split: b80bc63cf466f9751e8059c0abb4a4d73b23efbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there is some issue with the new project names introduced in this pull request. I tried to maintain backward compatibility here, but I'll happily change it.
This change is