Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests for C++ CI #888

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Run tests for C++ CI #888

merged 1 commit into from
Oct 8, 2021

Conversation

varunagrawal
Copy link
Collaborator

I made an error when improving the performance of the CI due to which the tests were not being run. This PR fixes it.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug ci Related to the Continuous Integration pipeline labels Oct 8, 2021
@varunagrawal varunagrawal self-assigned this Oct 8, 2021
johnwlambert
johnwlambert approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ProfFan ProfFan merged commit a74008d into develop Oct 8, 2021
@ProfFan ProfFan deleted the fix/ci-tests branch October 8, 2021 18:25
@varunagrawal
Copy link
Collaborator Author

Thanks for merging this Fan! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwlambert johnwlambert johnwlambert approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug ci Related to the Continuous Integration pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @johnwlambert @ProfFan