Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombinedImuFactor: Add bias effect on position jacobian #874

Merged
merged 45 commits into from
Aug 21, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
5e735e1
minor improvements to CombinedImuFactor
varunagrawal Sep 16, 2021
9dbb431
account for bias on position in jacobians of CombinedImuFactor
varunagrawal Sep 16, 2021
7e48962
Add unit test for checking covariance of CombinedImuFactor
varunagrawal Sep 17, 2021
b0fcd17
additional comments to make understanding the code easier
varunagrawal Sep 17, 2021
5656308
no need to assign negative to jacobians as they cancel out later
varunagrawal Sep 17, 2021
810f973
add details about noise propagation for CombinedImuFactor in ImuFacto…
varunagrawal Sep 17, 2021
da220dc
Add the Preintegrated IMU jacobians tech report and mention it in the…
varunagrawal Sep 18, 2021
a516415
update ImuFactor reference
varunagrawal Sep 20, 2021
61f2cf7
Merge branch 'develop' into fix/368
varunagrawal Sep 20, 2021
28d0393
add test for checking covariances between ImuFactor and CombinedImuFa…
varunagrawal Sep 19, 2021
a10c776
print statements in ImuFactor
varunagrawal Sep 19, 2021
65bbe6b
typedef for Vector15
varunagrawal Sep 19, 2021
3a3640c
updated CombinedImuFactor covariance with additional off-diagonal ele…
varunagrawal Sep 19, 2021
3132cfb
CombinedScenarioRunner
varunagrawal Sep 19, 2021
5371214
actually test the covariances and fix bug
varunagrawal Sep 20, 2021
10a7333
update test with comments
varunagrawal Sep 21, 2021
755c752
update ImuFactor doc
varunagrawal Sep 21, 2021
bbde7b9
remove print statements
varunagrawal Sep 21, 2021
a2bf0c4
minor refactoring
varunagrawal Sep 21, 2021
aa4a163
updated ImuFactor doc with details about CombinedImuFactor
varunagrawal Sep 28, 2021
0968c60
added details about covariance discretization with references
varunagrawal Sep 28, 2021
6bc9b50
add test for MC based covariance estimation
varunagrawal Sep 30, 2021
af714cd
undo name change from 984a90
varunagrawal Sep 28, 2021
e38ea50
detailed implementation of CombinedImuFactor noise propagation
varunagrawal Sep 28, 2021
3cee1b7
test passes
varunagrawal Sep 30, 2021
dfa32e5
lyx update
varunagrawal Oct 10, 2021
40e6d8b
formatting
varunagrawal Oct 10, 2021
995710f
update PDF doc
varunagrawal May 5, 2022
2d3859d
Merge branch 'develop' into fix/combined-imu
varunagrawal May 5, 2022
239dd62
Merge branch 'develop' into fix/combined-imu-cov
varunagrawal May 5, 2022
008bb93
Merge branch 'develop' into fix/368
varunagrawal May 5, 2022
63e2a59
Merge branch 'fix/368' into fix/combined-imu-cov
varunagrawal May 5, 2022
f0be857
Merge branch 'fix/combined-imu-cov' into fix/combined-imu
varunagrawal May 5, 2022
8dbbb1f
fix test
varunagrawal May 6, 2022
ce7c71b
fix test
varunagrawal May 8, 2022
a17134d
minor refactor to follow the math better
varunagrawal May 8, 2022
cb75d92
use prior naming scheme for bias jacobians
varunagrawal May 22, 2022
bbd1e3f
update Lyx document based on Luca's review
varunagrawal Jul 3, 2022
4244345
Merge pull request #882 from borglab/fix/combined-imu
varunagrawal Jul 5, 2022
c767dfa
Merge pull request #879 from borglab/fix/combined-imu-cov
varunagrawal Jul 20, 2022
2d41b01
change python CI cores to 1
varunagrawal Jul 20, 2022
8a33a5b
Revert "change python CI cores to 1"
varunagrawal Jul 22, 2022
322c080
Merge branch 'develop' into fix/368
varunagrawal Jul 22, 2022
ac28b0e
fix setter and getter for biasAccOmegaInit
varunagrawal Aug 2, 2022
103c78b
revert name change, save for another PR
varunagrawal Aug 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
minor improvements to CombinedImuFactor
  • Loading branch information
varunagrawal committed Sep 16, 2021
commit 5e735e10f7c2b731b831c5f1ffec7631f0fc90e6
15 changes: 8 additions & 7 deletions examples/CombinedImuFactorsExample.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,14 @@ namespace po = boost::program_options;

po::variables_map parseOptions(int argc, char* argv[]) {
po::options_description desc;
desc.add_options()("help,h", "produce help message")(
"data_csv_path", po::value<string>()->default_value("imuAndGPSdata.csv"),
"path to the CSV file with the IMU data")(
"output_filename",
po::value<string>()->default_value("imuFactorExampleResults.csv"),
"path to the result file to use")("use_isam", po::bool_switch(),
"use ISAM as the optimizer");
desc.add_options()("help,h", "produce help message") // help message
("data_csv_path", po::value<string>()->default_value("imuAndGPSdata.csv"),
"path to the CSV file with the IMU data") // path to the data file
("output_filename",
po::value<string>()->default_value("imuFactorExampleResults.csv"),
"path to the result file to use") // filename to save results to
("use_isam", po::bool_switch(),
"use ISAM as the optimizer"); // flag for ISAM optimizer

po::variables_map vm;
po::store(po::parse_command_line(argc, argv, desc), vm);
Expand Down
5 changes: 5 additions & 0 deletions gtsam/navigation/CombinedImuFactor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ void PreintegratedCombinedMeasurements::resetIntegration() {
//------------------------------------------------------------------------------
void PreintegratedCombinedMeasurements::integrateMeasurement(
const Vector3& measuredAcc, const Vector3& measuredOmega, double dt) {
if (dt <= 0) {
throw std::runtime_error(
"PreintegratedCombinedMeasurements::integrateMeasurement: dt <=0");
}

// Update preintegrated measurements.
Matrix9 A; // overall Jacobian wrt preintegrated measurements (df/dx)
Matrix93 B, C;
Expand Down