Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImuFactor Fixes #869

Merged
merged 4 commits into from
Sep 6, 2021
Merged

ImuFactor Fixes #869

merged 4 commits into from
Sep 6, 2021

Conversation

varunagrawal
Copy link
Collaborator

  • wrapped smart flag for noise models.

@varunagrawal varunagrawal self-assigned this Sep 5, 2021
dellaert
dellaert approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Would be nice to add a screenshot in the PR comment

@varunagrawal
Copy link
Collaborator Author

Plots are exactly the same. I was just getting a lot of terminal noise due to the deprecation warnings so I resolved that.

The wrapping happened more as a consequence of debugging IMU sequences with noise so I could check the various covariances.

@varunagrawal varunagrawal merged commit e5bad52 into develop Sep 6, 2021
@varunagrawal varunagrawal deleted the fix/imu-factor-example branch September 6, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert