Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python type annotations to some older python files #844

Merged
merged 8 commits into from
Aug 17, 2021

Conversation

johnwlambert
Copy link
Contributor

@johnwlambert johnwlambert commented Aug 12, 2021

Files affected:

  • test_Pose3SLAMExample.py
  • circlePose3.py
  • plot.py
  • visual_data_generator.py

Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the Python unit tests are failing, but otherwise looks good :)

Base automatically changed from wrap-gnc to develop August 13, 2021 04:32
@johnwlambert
Copy link
Contributor Author

It appears that the Python unit tests are failing, but otherwise looks good :)

thanks @ProfFan, should be fixed now

@ProfFan
Copy link
Collaborator

ProfFan commented Aug 17, 2021

Noice!

@ProfFan ProfFan merged commit 4ea2b2e into develop Aug 17, 2021
@varunagrawal varunagrawal deleted the add-python-type-hints branch August 23, 2021 22:40
@varunagrawal
Copy link
Collaborator

There's a missing import for Pose3 that was introduced in this PR. We really need to add more Python tests.

@varunagrawal
Copy link
Collaborator

Also, @johnwlambert what formatter are you using? We all use yapf in case you use something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants