Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing getter in ProjectionFactor #842

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Add missing getter in ProjectionFactor #842

merged 1 commit into from
Aug 11, 2021

Conversation

jlblancoc
Copy link
Member

This simply adds a missing getter.

Supersedes #831, to have a cleaner commit line.

@jlblancoc jlblancoc added the quick-review Quick and easy PR to review label Aug 10, 2021
This was referenced Aug 10, 2021
Closed
Closed
varunagrawal
varunagrawal approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit f7ef6f7 into develop Aug 11, 2021
@varunagrawal varunagrawal deleted the fix/missing-visual-factor-getter branch August 11, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlblancoc @varunagrawal