Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Similarity3 export declarations and wrapper #719

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Fix the Similarity3 export declarations and wrapper #719

merged 1 commit into from
Mar 18, 2021

Conversation

varunagrawal
Copy link
Collaborator

Straightforward.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug quick-review Quick and easy PR to review easy-fix Quick and easy to fix labels Mar 18, 2021
@varunagrawal varunagrawal self-assigned this Mar 18, 2021
@varunagrawal varunagrawal added the high-priority Need this done quickly label Mar 18, 2021
@johnwlambert
Copy link
Contributor

Thanks for the PR @varunagrawal . Seems CI failed?

@varunagrawal
Copy link
Collaborator Author

CI is failing due to #717, not this PR. I need this PR to get 717 landed.

@johnwlambert
Copy link
Contributor

Sure, ok I approve then

@varunagrawal varunagrawal merged commit 9e3813a into develop Mar 18, 2021
@varunagrawal varunagrawal deleted the fix/sim3 branch March 18, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwlambert johnwlambert johnwlambert approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug easy-fix Quick and easy to fix high-priority Need this done quickly quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @johnwlambert